Fix race in StorageSystemRocksDB#29289
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Sep 26, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
vdimir
changed the title
vdimir
changed the title
robot-clickhouse
added
pr-bugfix
vdimir
force-pushed
the
issue-29227-rocksdb-truncate
branch
from
75affb0 to
70ee500
Compare
vdimir
force-pushed
the
issue-29227-rocksdb-truncate
branch
from
70ee500 to
9ca9a66
Compare
vdimir
commented
Sep 23, 2021
azat
reviewed
Sep 23, 2021
Co-authored-by: Azat Khuzhin <[email protected]>
Contributor
|
@vdimir should we try to fix flacky integration test test_rocksdb_options in scope of this pull request ? |
robot-clickhouse
added
pr-not-for-changelog
alexey-milovidov
approved these changes
Sep 26, 2021
Member
|
@Mergifyio update |
Contributor
|
Command
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix race in
StorageSystemRocksDB, close #29227