Make index or partition filter valid in tuple like (k1, k2)=(v1,v2)#29281
Make index or partition filter valid in tuple like (k1, k2)=(v1,v2)#29281vdimir merged 7 commits intoClickHouse:masterfrom
(k1, k2)=(v1,v2)#29281Conversation
|
You have a great example in your issue, let's try to add it as test. Also there's some commits |
@vdimir Thanks for your reviewing ! I will try to add some tests and rebase the unnecessary commits. |
97c991f to
9acf05c
Compare
|
@lingtaolf I guess you can / should use "force..." for tests: --force_index_by_date arg Throw an exception if there is a partition key in a table, and it is not used. |
@den-crane Done ! Thanks for you advices . |
|
I fixed fuzzer error and added support both type of expressions Analyzing of expression like |
vdimir
left a comment
There was a problem hiding this comment.
Thank you for your changes!
Let's wait for CI and merge if it'll be ok.
@vdimir Thanks for your help ! |
|
CI stuck for some reason, I'm going to rebase branch |
6ab91d1 to
ce844e4
Compare
ce844e4 to
7444d64
Compare
|
Added a couple of testcases with tuple in tuple and rebase on master, hope final change, will wait CI and merge. |
Known solved issue |
Fixes: ClickHouse#29281 Fixes: test_cluster_copier/test_three_nodes.py::test
@vdimir @lingtaolf |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Primary key index and partition filter can work in tuple
This PR solved problem in #29269