Skip to content

Parallel reading from replicas#29279

Merged
nikitamikhaylov merged 71 commits intoClickHouse:masterfrom
nikitamikhaylov:parallel-reading-from-replicas
Dec 9, 2021
Merged

Parallel reading from replicas#29279
nikitamikhaylov merged 71 commits intoClickHouse:masterfrom
nikitamikhaylov:parallel-reading-from-replicas

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Sep 22, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added an ability to read from all replicas within a shard during distributed query. To enable this, set allow_experimental_parallel_reading_from_replicas=true and max_parallel_replicas to any number. This closes #26748

Detailed description / Documentation draft:
We already have such mechanism, but it works only for tables with SAMPLE BY key. This feature will work for any kind of MergeTree tables. If max_parallel_replicas is set to some value > 1, then the old algorithm is enabled (backward compatible change).

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Sep 22, 2021
@nikitamikhaylov nikitamikhaylov force-pushed the parallel-reading-from-replicas branch from 03bd5df to 5de301c Compare September 24, 2021 12:33
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@nikitamikhaylov nikitamikhaylov force-pushed the parallel-reading-from-replicas branch from 5de301c to 5925c1c Compare September 28, 2021 20:05
@nikitamikhaylov nikitamikhaylov force-pushed the parallel-reading-from-replicas branch from 5925c1c to 46f5412 Compare September 29, 2021 14:05
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally ok

@KochetovNicolai
Copy link
Copy Markdown
Member

Ok, just need to disable for FINAL and we can merge.

@nikitamikhaylov
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 8, 2021

update

✅ Branch has been successfully updated

@nikitamikhaylov nikitamikhaylov merged commit dbf5091 into ClickHouse:master Dec 9, 2021
@ka1bi4
Copy link
Copy Markdown
Contributor

ka1bi4 commented Dec 11, 2021

Internal documentation ticket: DOCSUP-19955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎅 🎁 gift🎄 To make people wonder pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel processing on replicas, reworked.

6 participants