Implemented modifying table comments with ALTER TABLE t MODIFY COMMENT 'value'#29264
Merged
alesapin merged 5 commits intoClickHouse:masterfrom Sep 27, 2021
Enmk:governance/table_comment_update
Merged
Implemented modifying table comments with ALTER TABLE t MODIFY COMMENT 'value'#29264alesapin merged 5 commits intoClickHouse:masterfrom Enmk:governance/table_comment_update
ALTER TABLE t MODIFY COMMENT 'value'#29264alesapin merged 5 commits intoClickHouse:masterfrom
Enmk:governance/table_comment_update
Conversation
robot-clickhouse
added
doc-alert
pr-feature
alesapin
requested changes
Sep 23, 2021
alesapin
approved these changes
Sep 27, 2021
Member
|
Integration tests not affected. |
Contributor
|
Internal documentation ticket: DOCSUP-15458 |
Member
|
@alesapin, it's funny that even the test in this PR is wrong. It "cemented" the incorrect behavior. |
Member
|
@Enmk, it does not work at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implemented
ALTER TABLE x MODIFY COMMENTDetailed description / Documentation draft:
Users can now add\remove\modify comments on existing tables.
ALTER TABLE x MODIFY COMMENT 'new comment'- sets table comment to be anew comment, regardless if it was set before or not.ALTER TABLE x MODIFY COMMENT ''- removes a table comment.Comment change is reflected in both
system.tablesandSHOW CREATE TABLE.