Send UNKNOWN_DATABASE to the client (via TCP)#29229
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Sep 26, 2021
Merged
Send UNKNOWN_DATABASE to the client (via TCP)#29229alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Sep 21, 2021
azat
force-pushed
the
send-UNKNOWN_DATABASE-to-client
branch
from
4035c61 to
6107698
Compare
Before this patch:
$ clickhouse-client --database foo -q 'select 1'
Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)
After:
$ clickhouse-client --database foo -q 'select 1'
Received exception from server (version 21.11.1):
Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
(query: select 1)
Fixes: ClickHouse#26864 (cc @vitlibar)
Member
Author
Will rebase to re-trigger checks on CI |
azat
force-pushed
the
send-UNKNOWN_DATABASE-to-client
branch
from
6107698 to
b3d1bfc
Compare
This was referenced Sep 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 27, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Sep 28, 2021
Backport #29229 to 21.10: Send UNKNOWN_DATABASE to the client (via TCP)
alexey-milovidov
added a commit
that referenced
this pull request
Sep 28, 2021
Backport #29229 to 21.9: Send UNKNOWN_DATABASE to the client (via TCP)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Send normal
Database doesn't exist error(UNKNOWN_DATABASE) to the client (via TCP) instead ofAttempt to read after eof(ATTEMPT_TO_READ_AFTER_EOF)Detailed description / Documentation draft:
Before this patch:
After:
Fixes: #26864 (cc @vitlibar)