Skip to content

Fix terminate on uncaught exception#29216

Merged
tavplubix merged 1 commit intomasterfrom
fix_29122
Sep 21, 2021
Merged

Fix terminate on uncaught exception#29216
tavplubix merged 1 commit intomasterfrom
fix_29122

Conversation

@tavplubix
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Detailed description / Documentation draft:
Fixes #29122

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 21, 2021
Copy link
Copy Markdown
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdimir vdimir self-assigned this Sep 21, 2021
@tavplubix tavplubix merged commit e54bd40 into master Sep 21, 2021
@tavplubix tavplubix deleted the fix_29122 branch September 21, 2021 17:12
@filimonov
Copy link
Copy Markdown
Contributor

Why 'not for changelog'? It's a bugfix, affecting released version

@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 21, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

It is related to temporary live views (not production) or something similar.

@vzakaznikov
Copy link
Copy Markdown
Contributor

Live view was just executing a query. So this exception could have come up in other scenarios.

tavplubix added a commit that referenced this pull request Sep 22, 2021
Backport #29216 to 21.8: Fix terminate on uncaught exception
tavplubix added a commit that referenced this pull request Sep 22, 2021
Backport #29216 to 21.7: Fix terminate on uncaught exception
tavplubix added a commit that referenced this pull request Sep 22, 2021
Backport #29216 to 21.10: Fix terminate on uncaught exception
tavplubix added a commit that referenced this pull request Sep 22, 2021
Backport #29216 to 21.9: Fix terminate on uncaught exception
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Liveview-related (?) sigabort

7 participants