Skip to content

Merging #28634#29215

Merged
kitaisreal merged 2 commits intomasterfrom
bloom-filter-index-map-data-type
Sep 21, 2021
Merged

Merging #28634#29215
kitaisreal merged 2 commits intomasterfrom
bloom-filter-index-map-data-type

Conversation

@kitaisreal
Copy link
Copy Markdown
Contributor

@kitaisreal kitaisreal commented Sep 21, 2021 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Original pull request #28634.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add bloom filter skip index for map data type. Author @fuwhu.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Sep 21, 2021
@kitaisreal kitaisreal force-pushed the bloom-filter-index-map-data-type branch from ae922a4 to 8962672 Compare September 21, 2021 07:59
@kitaisreal kitaisreal force-pushed the bloom-filter-index-map-data-type branch from b13aaec to 15c9315 Compare September 21, 2021 12:08
@kitaisreal kitaisreal self-assigned this Sep 21, 2021
@kitaisreal kitaisreal merged commit 19d7015 into master Sep 21, 2021
@kitaisreal kitaisreal deleted the bloom-filter-index-map-data-type branch September 21, 2021 17:31
@FrankChen021
Copy link
Copy Markdown
Contributor

FrankChen021 commented May 9, 2023

This merge commit has been reverted and re-implemented by commit 92fd6b3 which was directly committed to the master branch

commit 92fd6b376f16b3e24d8466eb2c9be727b44eefde
Author: Maksim Kita <[email protected]>
Date:   Wed Sep 22 12:45:48 2021 +0300

    Updated bloom filter index for map type to work with mapKeys function

 src/Interpreters/BloomFilter.cpp                                | 13 -------------
 src/Interpreters/BloomFilterHash.h                              | 21 ---------------------
 src/Storages/MergeTree/MergeTreeIndexConditionBloomFilter.cpp   | 43 ++++++++++++++++++++++++-------------------
 tests/queries/0_stateless/2021_map_bloom_filter_index.reference | 12 ++++++++++++
 tests/queries/0_stateless/2021_map_bloom_filter_index.sql       | 30 ++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+), 53 deletions(-)

A pitty that current doc does not depict the correct use of bloom filter on Map type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kitaisreal kitaisreal

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kitaisreal @FrankChen021 @robot-clickhouse @fuwhu