Skip to content

Fix integer underflow in function quantile#29203

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-ubsan
Oct 2, 2021
Merged

Fix integer underflow in function quantile#29203
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-ubsan

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Sep 20, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #29166.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 20, 2021
@alexey-milovidov alexey-milovidov self-assigned this Sep 20, 2021
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Sep 28, 2021

I've just made a mistake and generated test reference with wrong clickhouse version.

@alexey-milovidov
Copy link
Copy Markdown
Member

Something is wrong with integration tests.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Oct 2, 2021

As I remember there was some internal problems with CI.

Get "https://registry-1.docker.io/v2/": net/http: TLS handshake timeout

@CurtizJ CurtizJ merged commit b64bbb5 into ClickHouse:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuantileExact.h:240:120: runtime error: signed integer overflow

4 participants