keeper-converter add the last logfile that is less than the zxid.#29030
Merged
alesapin merged 2 commits intoClickHouse:masterfrom Sep 20, 2021
Merged
keeper-converter add the last logfile that is less than the zxid.#29030alesapin merged 2 commits intoClickHouse:masterfrom
alesapin merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
nicelulu
changed the title
Contributor
Author
|
The log file name of zookeeper is the index where the log starts. If you only apply log files larger than the snapshot last index, part of the log will be missed. |
robot-clickhouse
added
pr-improvement
Contributor
Author
|
@alesapin Can you review this pr, thank you. |
alesapin
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in
clickhouse-keeper-converterwhich can lead to some data loss while restoring from ZooKeeper logs (not snapshot).