Skip to content

Add function zookeeperSessionUptime(), fix some flaky tests#28983

Merged
tavplubix merged 5 commits intomasterfrom
func_zookeeper_session_uptime
Sep 20, 2021
Merged

Add function zookeeperSessionUptime(), fix some flaky tests#28983
tavplubix merged 5 commits intomasterfrom
func_zookeeper_session_uptime

Conversation

@tavplubix
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added function zookeeperSessionUptime() which returns uptime of current ZooKeeper session in seconds.

Detailed description / Documentation draft:

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Sep 13, 2021
@tavplubix tavplubix changed the title Add function zookeeperSessionUptime(), fix some flacky tests Add function zookeeperSessionUptime(), fix some flaky tests Sep 13, 2021
@nikitamikhaylov nikitamikhaylov self-assigned this Sep 14, 2021
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these functions into on .cpp file ?

@tavplubix tavplubix force-pushed the func_zookeeper_session_uptime branch from 1c81a13 to d0c3b87 Compare September 15, 2021 21:18
@tavplubix tavplubix merged commit 66bc619 into master Sep 20, 2021
@tavplubix tavplubix deleted the func_zookeeper_session_uptime branch September 20, 2021 11:47
@sevirov
Copy link
Copy Markdown
Contributor

sevirov commented Sep 20, 2021

Internal documentation ticket: DOCSUP-15137

@amosbird
Copy link
Copy Markdown
Collaborator

amosbird commented Oct 8, 2021

This PR did a refactoring over server constant functions. It would be great to have some description in the Detailed description / Documentation draft: section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants