Add four letter commands to keeper by JackyWoo · Pull Request #28981 · ClickHouse/ClickHouse

JackyWoo · 2021-09-13T13:01:32Z

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

We need to implement similar commands in clickhouse-keeper: https://zookeeper.apache.org/doc/r3.4.8/zookeeperAdmin.html#sc_zkCommands

Detailed description / Documentation draft:

When startup register 4 letter word command with a <code, command_executor> map. The code is name reinterpreted int32.
When new connection comes, first extract the first 4 characters and check whether it is 4lw command, if yes, run the command.
add some methods to KeeperStorageDispatcher to collect server info.

Because the first request of a connection is hand shake request whose first 4 characters is request length and the length is fixed 44 or 45. All 4lw code is larger than 2^24 or lower than 0, so collision never happens.

The pr is still WIP the first commit only add 'ruok' command.

The pr will close #28649 #26976.

...cker/control/jepsen/target/classes/META-INF/maven/jepsen.keeper/jepsen.keeper/pom.properties

JackyWoo · 2021-09-15T10:14:59Z

@alesapin if the pr is ok, I will work on the rest part.

alesapin

In general LGTM. Let's implement several more interesting commands!

src/Coordination/FourLetterCommand.h

alesapin · 2021-09-27T12:30:39Z

@JackyWoo How is it going?)

CLAassistant · 2021-09-28T08:31:44Z

All committers have signed the CLA.

JackyWoo · 2021-09-30T02:57:31Z

@alesapin Sorry for late reply. Because We are in the biggest event of the year, the work delayed. I will add more commands in two or three weaks.

JackyWoo · 2021-10-27T16:08:01Z

Add 4lw command: mntr, srst, conf

mntr output almost like Zookeeper mntr output
srst can reset mntr counter metrics
conf print keeper_server configuration
Merge mastr branch

Change log

add some command with test
add some interfaces to KeeprServer, StateMachine, KeeperDispatcher which provides some useful information
add KeeperSettings to encapsulate keeper configuration

alesapin

Cool. Are you going to add more commands in this PR? Or we can merge it and continue in a new one?

src/Coordination/CoordinationSettings.cpp

JackyWoo · 2021-10-28T11:07:23Z

@alesapin I intend to add most Zookeeper 4lw commands and white list feature. What is your opinion?
Adn shell we merge the pr first? Because merging conflicts may be a hard work.

alesapin · 2021-10-28T13:15:28Z

@alesapin I intend to add most Zookeeper 4lw commands and white list feature. What is your opinion? Adn shell we merge the pr first? Because merging conflicts may be a hard work.

Great idea. Let's continue in this PR, I'm not going to create huge changes in Coordination/ directory.

JackyWoo · 2021-10-29T10:33:32Z

Great idea. Let's continue in this PR, I'm not going to create huge changes in Coordination/ directory.

Ok, thank you.

In mntr command calculating approximately data size will traverse the whole state machine which may block user requests. And there is another solution embeding data size logic into SnapshotableHashTable. But it require element has method such as size which will introduce limitation to SnapshotableHashTable.

So what's you opinion?

alesapin · 2021-10-29T15:40:27Z

Great idea. Let's continue in this PR, I'm not going to create huge changes in Coordination/ directory.

Ok, thank you.

In mntr command calculating approximately data size will traverse the whole state machine which may block user requests. And there is another solution embeding data size logic into SnapshotableHashTable. But it require element has method such as size which will introduce limitation to SnapshotableHashTable.

So what's you opinion?

I think it's Ok. SnapshotableHashTable has very limited use, so it shouldn't affect anything.

JackyWoo · 2021-10-29T16:45:58Z

Ok, I will work on it.

JackyWoo · 2021-11-01T05:24:20Z

@alesapin add sizeOf util functions to SnapshotableHashTable which were chosen at compile time according to whether element has a size method.

…ckHouse into JackyWoo_add_4_letter_words_commands

src/Common/getCurrentProcessFDCount.cpp

JackyWoo

Very nice work, thanks.

src/Coordination/FourLetterCommand.cpp

tests/queries/shell_config.sh

…ckHouse into JackyWoo_add_4_letter_words_commands

JackyWoo

approved

src/Coordination/Keeper4LWInfo.h

src/Coordination/KeeperDispatcher.cpp

tests/queries/shell_config.sh

src/Coordination/tests/gtest_coordination.cpp

…ckHouse into JackyWoo_add_4_letter_words_commands

alesapin · 2021-11-22T15:31:26Z

@Mergifyio update

mergify · 2021-11-22T15:32:54Z

update

☑️ Nothing to do

Details

-closed [:pushpin: update requirement]
#commits-behind>0 [:pushpin: update requirement]

alesapin · 2021-11-23T10:33:22Z

Finally fixed:

/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.659512 [ 26617 ] {} <Fatal> BaseDaemon: ########################################
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.666285 [ 26617 ] {} <Fatal> BaseDaemon: (version 21.12.1.8825, build id: 7EAA75FE01C502B751BD36D980EEF0442297DA43) (from thread 2697) (no query) Received signal Aborted (6)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.670013 [ 26617 ] {} <Fatal> BaseDaemon: 
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.672388 [ 26617 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f2f5414218b 0x7f2f54121859 0x1c06502e 0x209e3b08 0x209e3a75 0xd3aa51b 0x1cc42f59 0xd3bd04d 0xd3bcf85 0x1debd12b 0x1debd2ee 0x1ed33e2e 0x1ee27c27 0x1ee254ec 0x7f2f542f7609 0x7f2f5421e293
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.673487 [ 26617 ] {} <Fatal> BaseDaemon: 3. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.683707 [ 26617 ] {} <Fatal> BaseDaemon: 4. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.701779 [ 26617 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../base/daemon/BaseDaemon.cpp:454: terminate_handler() @ 0x1c06502e in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.721355 [ 26617 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x209e3b08 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:49.729291 [ 26617 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:0: std::terminate() @ 0x209e3a75 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.229384 [ 26617 ] {} <Fatal> BaseDaemon: 8. ? @ 0xd3aa51b in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.278621 [ 26617 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:89: ? @ 0x1cc42f59 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.361595 [ 26617 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2474: std::__1::__shared_count::__release_shared() @ 0xd3bd04d in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.393948 [ 26617 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0xd3bcf85 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.492828 [ 26617 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../src/Server/KeeperTCPHandler.cpp:632: DB::KeeperTCPHandler::~KeeperTCPHandler() @ 0x1debd12b in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.630555 [ 26617 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../src/Server/KeeperTCPHandler.cpp:630: DB::KeeperTCPHandler::~KeeperTCPHandler() @ 0x1debd2ee in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.665356 [ 26617 ] {} <Fatal> BaseDaemon: 14.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1072: int std::__1::__cxx_atomic_fetch_sub<int>(std::__1::__cxx_atomic_base_impl<int>*, int, std::__1::memory_order)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.678260 [ 26617 ] {} <Fatal> BaseDaemon: 14.2. inlined from ../contrib/libcxx/include/atomic:1725: std::__1::__atomic_base<int, true>::fetch_sub(int, std::__1::memory_order)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.680215 [ 26617 ] {} <Fatal> BaseDaemon: 14.3. inlined from ../contrib/libcxx/include/atomic:1760: std::__1::__atomic_base<int, true>::operator--()
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.688048 [ 26617 ] {} <Fatal> BaseDaemon: 14.4. inlined from ../contrib/poco/Net/src/TCPServerDispatcher.cpp:236: Poco::Net::TCPServerDispatcher::endConnection()
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.692676 [ 26617 ] {} <Fatal> BaseDaemon: 14. ../contrib/poco/Net/src/TCPServerDispatcher.cpp:119: Poco::Net::TCPServerDispatcher::run() @ 0x1ed33e2e in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.710864 [ 26617 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:213: Poco::PooledThread::run() @ 0x1ee27c27 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.734268 [ 26617 ] {} <Fatal> BaseDaemon: 16.1. inlined from ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:156: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::assign(Poco::Runnable*)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.739546 [ 26617 ] {} <Fatal> BaseDaemon: 16.2. inlined from ../contrib/poco/Foundation/include/Poco/SharedPtr.h:208: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::operator=(Poco::Runnable*)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.756160 [ 26617 ] {} <Fatal> BaseDaemon: 16. ../contrib/poco/Foundation/src/Thread_POSIX.cpp:360: Poco::ThreadImpl::runnableEntry(void*) @ 0x1ee254ec in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.758285 [ 26617 ] {} <Fatal> BaseDaemon: 17. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.767138 [ 26617 ] {} <Fatal> BaseDaemon: 18. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.948280 [ 26616 ] {} <Fatal> BaseDaemon: 8. ? @ 0xd3aa51b in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:52.964452 [ 26616 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:89: ? @ 0x1cc42f59 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.020427 [ 26616 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2474: std::__1::__shared_count::__release_shared() @ 0xd3bd04d in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.078542 [ 26616 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0xd3bcf85 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.106284 [ 26616 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../src/Server/KeeperTCPHandler.cpp:632: DB::KeeperTCPHandler::~KeeperTCPHandler() @ 0x1debd12b in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.146149 [ 26616 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../src/Server/KeeperTCPHandler.cpp:630: DB::KeeperTCPHandler::~KeeperTCPHandler() @ 0x1debd2ee in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.161391 [ 26616 ] {} <Fatal> BaseDaemon: 14.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1072: int std::__1::__cxx_atomic_fetch_sub<int>(std::__1::__cxx_atomic_base_impl<int>*, int, std::__1::memory_order)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.163655 [ 26616 ] {} <Fatal> BaseDaemon: 14.2. inlined from ../contrib/libcxx/include/atomic:1725: std::__1::__atomic_base<int, true>::fetch_sub(int, std::__1::memory_order)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.165854 [ 26616 ] {} <Fatal> BaseDaemon: 14.3. inlined from ../contrib/libcxx/include/atomic:1760: std::__1::__atomic_base<int, true>::operator--()
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.170214 [ 26616 ] {} <Fatal> BaseDaemon: 14.4. inlined from ../contrib/poco/Net/src/TCPServerDispatcher.cpp:236: Poco::Net::TCPServerDispatcher::endConnection()
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.172304 [ 26616 ] {} <Fatal> BaseDaemon: 14. ../contrib/poco/Net/src/TCPServerDispatcher.cpp:119: Poco::Net::TCPServerDispatcher::run() @ 0x1ed33e2e in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.200445 [ 26616 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:213: Poco::PooledThread::run() @ 0x1ee27c27 in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.217797 [ 26616 ] {} <Fatal> BaseDaemon: 16.1. inlined from ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:156: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::assign(Poco::Runnable*)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.218933 [ 26616 ] {} <Fatal> BaseDaemon: 16.2. inlined from ../contrib/poco/Foundation/include/Poco/SharedPtr.h:208: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::operator=(Poco::Runnable*)
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.220526 [ 26616 ] {} <Fatal> BaseDaemon: 16. ../contrib/poco/Foundation/src/Thread_POSIX.cpp:360: Poco::ThreadImpl::runnableEntry(void*) @ 0x1ee254ec in /usr/bin/clickhouse
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.222241 [ 26616 ] {} <Fatal> BaseDaemon: 17. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.225577 [ 26616 ] {} <Fatal> BaseDaemon: 18. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.272362 [ 26617 ] {} <Fatal> BaseDaemon: Calculated checksum of the binary: 56E0317DB6CEECE62B1AAA9078259F89. There is no information about the reference checksum.
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:25:53.634259 [ 26616 ] {} <Fatal> BaseDaemon: Calculated checksum of the binary: 56E0317DB6CEECE62B1AAA9078259F89. There is no information about the reference checksum.
/var/log/clickhouse-server/clickhouse-server.log.2:2021.11.22 20:26:14.005281 [ 477 ] {} <Fatal> Application: Child process was terminated by signal 6.```

alesapin · 2021-11-24T10:26:41Z

Bugs in old infrastructure

alesapin · 2021-11-24T10:31:02Z

Stateless tests flaky check (address, actions) — fail: 4, passed: 93, unknown: 3 -- too many concurrent runs, it's ok.
Stress test (memory, actions) — Killed by signal (in clickhouse-server.log) -- reported: #31689
Stress test (thread, actions) — Test script failed -- unrelated, but strange failurе.
01622_defaults_for_url_engine -- unrelated, flaky.

robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Sep 13, 2021

alesapin added the can be tested label Sep 13, 2021

alesapin self-assigned this Sep 13, 2021

alesapin reviewed Sep 13, 2021

View reviewed changes

...cker/control/jepsen/target/classes/META-INF/maven/jepsen.keeper/jepsen.keeper/pom.properties Outdated Show resolved Hide resolved

alesapin reviewed Sep 17, 2021

View reviewed changes

src/Coordination/FourLetterCommand.h Outdated Show resolved Hide resolved

src/Coordination/FourLetterCommand.h Outdated Show resolved Hide resolved

src/Coordination/FourLetterCommand.h Outdated Show resolved Hide resolved

src/Coordination/FourLetterCommand.h Outdated Show resolved Hide resolved

JackyWoo force-pushed the add_4_letter_words_commands branch from f72f77d to fe28a52 Compare September 30, 2021 06:18

add 4lw commands to keeper

a60663e

JackyWoo force-pushed the add_4_letter_words_commands branch from 73a1321 to a60663e Compare October 27, 2021 14:05

JackyWoo added 2 commits October 27, 2021 22:26

adjust code style for keeper 4lw cmd

e5b0eed

dump new coordination settings

4908f71

JackyWoo added 2 commits October 28, 2021 14:19

fix test bug

9f0fe34

fix PVS check error

6f672df

alesapin reviewed Oct 28, 2021

View reviewed changes

src/Coordination/CoordinationSettings.cpp Outdated Show resolved Hide resolved

JackyWoo added 2 commits October 28, 2021 18:27

fix clang13 build error

239a13e

ignore superdigest whem dump keeper configuration

92a0b94

JackyWoo added 2 commits October 29, 2021 17:54

add 4lw white list to keeper

694306e

remove not used error code in FourLetterCommand.cpp

715f982

add sizeOf util function to SnapshotableHashTable

f24d430

alesapin added 2 commits November 19, 2021 12:31

Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/Cli…

f33e93e

…ckHouse into JackyWoo_add_4_letter_words_commands

More compatible output format

7820af7

JackyWoo commented Nov 19, 2021

View reviewed changes

src/Common/getCurrentProcessFDCount.cpp Show resolved Hide resolved

alesapin approved these changes Nov 19, 2021

View reviewed changes

JackyWoo commented Nov 19, 2021

View reviewed changes

src/Coordination/FourLetterCommand.cpp Outdated Show resolved Hide resolved

tests/queries/shell_config.sh Outdated Show resolved Hide resolved

alesapin and others added 6 commits November 19, 2021 13:49

Update shell_config.sh

7b7df05

Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/Cli…

c37aa14

…ckHouse into JackyWoo_add_4_letter_words_commands

Trim string

d1eba74

add new line to new xml file tail

0c0aba5

Fix tests

587a1a6

Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/Cli…

c2221b3

…ckHouse into JackyWoo_add_4_letter_words_commands

JackyWoo commented Nov 19, 2021

View reviewed changes

src/Coordination/Keeper4LWInfo.h Show resolved Hide resolved

src/Coordination/KeeperDispatcher.cpp Show resolved Hide resolved

tests/queries/shell_config.sh Outdated Show resolved Hide resolved

Update shell_config.sh

583c9a5

JackyWoo commented Nov 19, 2021

View reviewed changes

src/Coordination/tests/gtest_coordination.cpp Outdated Show resolved Hide resolved

alesapin added 5 commits November 19, 2021 18:22

Ignore overhead

1afef17

Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/Cli…

ea6a81a

…ckHouse into JackyWoo_add_4_letter_words_commands

Small changes

1cf204c

Merge branch 'master' into add_4_letter_words_commands

35de9e4

Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/Cli…

5825242

…ckHouse into JackyWoo_add_4_letter_words_commands

alesapin added 2 commits November 22, 2021 19:19

Bump

203477c

Flush bytes after 4 letter commands

16f034f

alesapin merged commit 646cf38 into ClickHouse:master Nov 24, 2021

alexey-milovidov mentioned this pull request Nov 24, 2021

Roadmap 2021 (discussion) #17623

Closed

pdv-ru mentioned this pull request Dec 27, 2021

DOCSUP-19044: Edit and translate to Russian (four letter commands to keeper) #33241

Merged

azat mentioned this pull request Sep 20, 2022

Support sql cmd to connect specify zookeeper #41207

Closed

Conversation

JackyWoo commented Sep 13, 2021

Uh oh!

Uh oh!

JackyWoo commented Sep 15, 2021

Uh oh!

alesapin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alesapin commented Sep 27, 2021

Uh oh!

CLAassistant commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackyWoo commented Sep 30, 2021

Uh oh!

JackyWoo commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add 4lw command: mntr, srst, conf

Change log

Uh oh!

alesapin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JackyWoo commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alesapin commented Oct 28, 2021

Uh oh!

JackyWoo commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alesapin commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackyWoo commented Oct 29, 2021

Uh oh!

JackyWoo commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JackyWoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JackyWoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alesapin commented Nov 22, 2021

Uh oh!

mergify bot commented Nov 22, 2021

☑️ Nothing to do

Uh oh!

alesapin commented Nov 23, 2021

Uh oh!

alesapin commented Nov 24, 2021

Uh oh!

alesapin commented Nov 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Sep 28, 2021 •

edited

Loading

JackyWoo commented Oct 27, 2021 •

edited

Loading

JackyWoo commented Oct 28, 2021 •

edited

Loading

JackyWoo commented Oct 29, 2021 •

edited

Loading

alesapin commented Oct 29, 2021 •

edited

Loading

JackyWoo commented Nov 1, 2021 •

edited

Loading