DOCSUP-13742: Support PARTITION BY for the s3 table function#28716
Merged
vdimir merged 7 commits intoClickHouse:masterfrom Sep 10, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-documentation
adevyatova
reviewed
Sep 9, 2021
Co-authored-by: Anna <[email protected]>
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
olgarev
commented
Sep 9, 2021
Contributor
Author
|
@vdimir Hi, please could you review this PR? |
Contributor
|
@excitoon , please look |
Contributor
|
LGTM |
vdimir
approved these changes
Sep 10, 2021
Member
There was a problem hiding this comment.
I've just changed file to object, seems it's more common in a context of S3 (but actually both are used)
https://aws.amazon.com/s3/faqs
UPD: Actually file already is used in our documentation for s3-related things, so let's it's better to keep it consistent, let's leave it
vdimir
reviewed
Sep 10, 2021
vdimir
reviewed
Sep 10, 2021
vdimir
reviewed
Sep 10, 2021
Member
|
I'm going to merge this, @excitoon if you will have any notes, then will make it in other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):