Reduce default settings for S3 multipart upload part size#28679
Merged
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom Sep 7, 2021
Merged
Reduce default settings for S3 multipart upload part size#28679nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-performance
Contributor
Author
|
Also this is a cause for less upload speed (~ 10% slower on my test cluster) |
nikitamikhaylov
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Reduce default settings for S3 multipart upload part size
Detailed description / Documentation draft:
Set default value for s3_min_upload_part_size and s3_max_single_part_upload_size to 32Mb.
s3_min_upload_part_size is a size for in-memory buffer, new value required for reduce memory usage.
s3_max_single_part_upload_size should be less or equal to s3_min_upload_part_size.