Conversation
robot-clickhouse
added
the
pr-build
robot-ch-test-poll3
added
the
submodule changed
alesapin
commented
Sep 3, 2021
| } | ||
| else | ||
| { | ||
| LOG_TEST(log, "Commit request for session {} with type {}, log id {}{}", |
Member
Author
There was a problem hiding this comment.
Just add one message for test.
azat
reviewed
Sep 3, 2021
| } while (false) | ||
|
|
||
|
|
||
| #define LOG_TEST(logger, ...) LOG_IMPL(logger, DB::LogsLevel::test, Poco::Message::PRIO_TEST, __VA_ARGS__) |
Member
There was a problem hiding this comment.
Interesting idea, maybe it should be under #ifdef so that only non-production binaries on CI (i.e. everything with relasetype != relwithdebinfo) will enable those messages?
Member
Author
There was a problem hiding this comment.
We use our production binary in all release tests (and it looks reasonable). I'll think about defence here, maybe at least some runtime check (env variable)...
Member
There was a problem hiding this comment.
I'm suggesting #ifdef here to make then literally no-op in relwithdebinfo/release builds (so that one will not care about additional cost for log messages, i.e. calling of some heavy method), but this has one downside - "variable maybe unused" warnings...
Member
There was a problem hiding this comment.
@azat It costs only one if.
Macro arguments are lazy evaluated.
Member
Author
|
Fuzzer: But now we have MemoryTracker in client, so we can set limit for it, so it should be Ok? |
2 tasks
the-horhe
pushed a commit
to the-horhe/clickhouse-driver
that referenced
this pull request
Oct 4, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add new log level
<test>for testing environments.