Simplier sessions expiration in Keeper and add comments#28519
Merged
Simplier sessions expiration in Keeper and add comments#28519
Conversation
alesapin
added
the
pr-must-backport
robot-clickhouse
added
the
pr-improvement
tavplubix
approved these changes
Sep 2, 2021
Comment on lines
22
to
23
| /// Session -> timeout ms | ||
| std::unordered_map<int64_t, int64_t> session_to_timeout; |
Member
There was a problem hiding this comment.
It's rather deadline than timeout, because it represents a point in time when session will be expired, not a time interval. Also it can be confused with KeeperStorage::session_and_timeout, which actually contains timeout (a time interval). Maybe rename it to session_to_deadline or session_to_expiration_time?
This was referenced Sep 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 6, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 6, 2021
alesapin
added a commit
that referenced
this pull request
Sep 8, 2021
Backport #28519 to 21.8: Simplier sessions expiration in Keeper and add comments
alesapin
added a commit
that referenced
this pull request
Sep 8, 2021
Backport #28519 to 21.9: Simplier sessions expiration in Keeper and add comments
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix strange sessions expiration logic in Keeper. Probably it should help in CI: https://clickhouse-test-reports.s3.yandex.net/0/6bd9b82141c98dcd7796fd9d08326831095ba519/stress_test_(debug).html#fail1