Forward profile events to client#28364
Conversation
6aa07d4 to
662a59e
Compare
90007b5 to
e002fc4
Compare
|
@Mergifyio update |
|
Command
|
5237752 to
c2ef62f
Compare
|
What will I see in case of distributed queries? |
|
@nikitamikhaylov Events for distributed queries are just forwarded (not merged anyhow) so the events from different servers can be distinguished on the client to show various summaries like: maximum memory usage across all servers, total memory usage summed across all servers, multiple individual progress bars, etc... |
|
This is how it's supposed to work, I did not read the PR though :) |
|
All profile events are supposed to be forwarded to the client (You can see that in |
| std::vector<ProfileEventsSnapshot> snapshots; | ||
| ProfileEventsSnapshot group_snapshot; | ||
| { | ||
| std::lock_guard guard(thread_group->mutex); |
There was a problem hiding this comment.
snapshots.reserve() after we acquire a lock?
f9050d4 to
bfdd34c
Compare
|
@novikd Maybe P.S. I've also verified that it does not decrease throughput of a simple |
|
@azat Better to avoid complications. |
|
@nikitamikhaylov The whole implementation is wrong.
|
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Send profile events from server to client. New packet type
ProfileEventswas introduced. Closes #26177.