Skip to content

Fix keeper logs disappearance#28360

Merged
alesapin merged 18 commits intomasterfrom
debug_keeper_lost_logs
Sep 3, 2021
Merged

Fix keeper logs disappearance#28360
alesapin merged 18 commits intomasterfrom
debug_keeper_lost_logs

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Aug 30, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix rare case when changes of clickhouse-keeper settings may lead to lost logs and server hung.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 30, 2021
@alesapin alesapin changed the title Trying to debug keeper logs disappearance Fix keeper logs disappearance Aug 31, 2021
@alesapin alesapin marked this pull request as ready for review August 31, 2021 09:56
@alesapin alesapin added the jepsen-test Need to test this PR with jepsen tests label Aug 31, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Sep 1, 2021

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 1, 2021

Command update: success

Branch has been successfully updated

@vdimir vdimir self-assigned this Sep 2, 2021
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Sep 3, 2021

All failures are known.

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Sep 3, 2021

Changes in Keeper cannot be related to performance tests failures

@alesapin alesapin merged commit 10f4d6b into master Sep 3, 2021
@alesapin alesapin deleted the debug_keeper_lost_logs branch September 3, 2021 09:38
alexey-milovidov added a commit that referenced this pull request Sep 8, 2021
Backport #28360 to 21.9: Fix keeper logs disappearance
alesapin added a commit that referenced this pull request Sep 9, 2021
Backport #28360 to 21.8: Fix keeper logs disappearance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jepsen-test Need to test this PR with jepsen tests pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants