Fix rare case when watch response received before request response#28197
Merged
Fix rare case when watch response received before request response#28197
Conversation
Member
Author
|
Why did so many random tests failed without logs? |
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
Member
Author
tavplubix
approved these changes
Aug 27, 2021
Member
Author
|
|
Member
|
Looks like docker daemon hung: |
Member
|
From another task (which is also going to fail with timeout due to hung docker): |
This was referenced Aug 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 30, 2021
…efore request response
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 30, 2021
…efore request response
vitlibar
pushed a commit
that referenced
this pull request
Aug 31, 2021
Backport #28197 to 21.9: Fix rare case when watch response received before request response
vitlibar
pushed a commit
that referenced
this pull request
Aug 31, 2021
Backport #28197 to 21.8: Fix rare case when watch response received before request response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a rare bug in
clickhouse-keeperwhen the client can receive a watch response before request-response.