Maybe fix livelock in ZooKeeper client#28195
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
alesapin
reviewed
Aug 27, 2021
| { | ||
| expired = true; | ||
| /// No new requests will appear in queue after close() | ||
| bool was_closed = requests_queue.close(); |
Member
There was a problem hiding this comment.
Uclear interface or variable name. If close() returned false then it was actually closed?
|
|
||
| if (in->poll(max_wait)) | ||
| { | ||
| if (expired) |
tavplubix
force-pushed
the
maybe_fix_livelock_in_zookeeper_client
branch
from
7be30f6 to
7ddb4a9
Compare
alesapin
approved these changes
Aug 30, 2021
Member
Author
|
ClickHouse special build check - I don't see error messages in the build log, looks like some CI issue |
tavplubix
added
the
pr-must-backport
This was referenced Oct 1, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 1, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 1, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 1, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 1, 2021
tavplubix
added a commit
that referenced
this pull request
Oct 4, 2021
Backport #28195 to 21.9: Maybe fix livelock in ZooKeeper client
tavplubix
added a commit
that referenced
this pull request
Oct 4, 2021
Backport #28195 to 21.8: Maybe fix livelock in ZooKeeper client
tavplubix
added a commit
that referenced
this pull request
Oct 4, 2021
Backport #28195 to 21.7: Maybe fix livelock in ZooKeeper client
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Detailed description / Documentation draft:
Maybe it will fix #27529 (comment)