Destroy main_config_reloader before shared context.#28088
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Aug 24, 2021
Merged
Conversation
This tries to fix crash reported in a comment ClickHouse#24404 (comment).
robot-clickhouse
added
the
pr-bugfix
kitaisreal
approved these changes
Aug 24, 2021
This was referenced Aug 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 25, 2021
kitaisreal
added a commit
that referenced
this pull request
Aug 25, 2021
Backport #28088 to 21.9: Destroy `main_config_reloader` before shared context.
kitaisreal
added a commit
that referenced
this pull request
Aug 25, 2021
Backport #28088 to 21.8: Destroy `main_config_reloader` before shared context.
kitaisreal
added a commit
that referenced
this pull request
Aug 25, 2021
Backport #28088 to 21.7: Destroy `main_config_reloader` before shared context.
kitaisreal
added a commit
that referenced
this pull request
Aug 25, 2021
Backport #28088 to 21.6: Destroy `main_config_reloader` before shared context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to fix crash reported in a comment
#24404 (comment).
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix extremely rare segfaults on shutdown due to incorrect order of context/config reloader shutdown.