Skip to content

Set version of tzlocal to 2.1#28063

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
vitlibar:set-fixed-version-of-tzlocal
Aug 24, 2021
Merged

Set version of tzlocal to 2.1#28063
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
vitlibar:set-fixed-version-of-tzlocal

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Aug 24, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Not for changelog

This PR must fix issues with integration tests and testflows tests:

test_dictionaries_all_layouts_separate_sources/test_cassandra.py:
AttributeError: 'backports.zoneinfo.ZoneInfo' object has no attribute 'localize'

/clickhouse/datetime64 extended range:
ModuleNotFoundError: No module named 'pytz'

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 24, 2021
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Aug 24, 2021

Maybe explicitly install pytz?

@alesapin alesapin self-assigned this Aug 24, 2021
@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Aug 24, 2021

Maybe explicitly install pytz?

No, that won't help because in addition to the dependency on pytz there are also other changes in tzlocal, for example our code calls the function tzlocal.get_localzone() which returns instances of different types in tzlocal 2.1 and tzlocal 3.0.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Aug 24, 2021

Maybe explicitly install pytz?

No, that won't help because in addition to the dependency on pytz there are also other changes in tzlocal, for example our code calls the function tzlocal.get_localzone() which returns instances of different types in tzlocal 2.1 and tzlocal 3.0.

Yes, it's clear to me, but explicit pytz install will be more obvious. Let's install both pytz and tzlocal of the required version?

@vitlibar vitlibar force-pushed the set-fixed-version-of-tzlocal branch from b42f91c to 8dc128f Compare August 24, 2021 11:08
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Aug 24, 2021

Error response from daemon: Dockerfile parse error line 83: unknown instruction: REDIS???

@vitlibar vitlibar mentioned this pull request Aug 24, 2021
Merged
@alexey-milovidov alexey-milovidov merged commit 47cc6c5 into ClickHouse:master Aug 24, 2021
@alexey-milovidov alexey-milovidov self-assigned this Aug 24, 2021
@azat azat mentioned this pull request Aug 25, 2021
Merged
@vitlibar vitlibar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 30, 2021
This was referenced Aug 30, 2021
Merged
Merged
Merged
Merged
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 30, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Aug 30, 2021
Backport #28063 to 21.7: Set version of tzlocal to 2.1
2f74fac
robot-clickhouse pushed a commit that referenced this pull request Aug 30, 2021
Backport #28063 to 21.6: Set version of tzlocal to 2.1
e647ea1
This was referenced Aug 30, 2021
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Aug 30, 2021
Backport #28063 to 21.9: Set version of tzlocal to 2.1
b4a4f2f
robot-clickhouse pushed a commit that referenced this pull request Aug 30, 2021
Backport #28063 to 21.8: Set version of tzlocal to 2.1
e217439
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 30, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Aug 30, 2021
Backport #28063 to 21.3: Set version of tzlocal to 2.1
575fde6
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 30, 2021
Merged
vitlibar pushed a commit that referenced this pull request Aug 31, 2021
Merge pull request #28378 from ClickHouse/backport/21.9/28063
0bc5117 
Backport #28063 to 21.9: Set version of tzlocal to 2.1
vitlibar pushed a commit that referenced this pull request Aug 31, 2021
Merge pull request #28379 from ClickHouse/backport/21.8/28063
0dda4ca 
Backport #28063 to 21.8: Set version of tzlocal to 2.1
vitlibar pushed a commit that referenced this pull request Aug 31, 2021
Merge pull request #28376 from ClickHouse/backport/21.7/28063
bef9604 
Backport #28063 to 21.7: Set version of tzlocal to 2.1
vitlibar pushed a commit that referenced this pull request Aug 31, 2021
Merge pull request #28380 from ClickHouse/backport/21.3/28063
625fafc 
Backport #28063 to 21.3: Set version of tzlocal to 2.1
vitlibar pushed a commit that referenced this pull request Aug 31, 2021
Merge pull request #28377 from ClickHouse/backport/21.6/28063
7878154 
Backport #28063 to 21.6: Set version of tzlocal to 2.1
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alesapin alesapin

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vitlibar @alesapin @alexey-milovidov @Felixoid @robot-clickhouse