Skip to content

Improve server logs checking in integration tests#27934

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:integration-tests-improve-check
Aug 31, 2021
Merged

Improve server logs checking in integration tests#27934
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:integration-tests-improve-check

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 20, 2021 •
edited
Loading

After this patch:

  • the check will be done on the host, so if the container is died (due to some fatal ClickHoues error) the error will still be catched (like in Fix incorrect assertion during writing to StorageKafka #27885)
  • the check will be done after the container terminates, so if there will be some Fatal messages on termination they will be catched.
  • the Fatal messages will trigger test failure

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Refs: #26547

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 20, 2021
@azat azat marked this pull request as draft August 20, 2021 20:17
@azat
Improve server logs checking in integration tests
2785aca 
Since some dtors will be called only after SIGTERM, check after server
is exited.

Also Fatal messages does not fails tests before.
@azat azat force-pushed the integration-tests-improve-check branch from 608421b to 2785aca Compare August 21, 2021 20:34
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 21, 2021

Refs: #26547

After this patch Fatal messages will not be hidden in integration tests anymore (like in #27885)

@azat azat marked this pull request as ready for review August 21, 2021 20:35
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 21, 2021

Cc @qoega

@azat azat mentioned this pull request Aug 21, 2021
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 31, 2021

@qoega can you take a look please?

@alexey-milovidov alexey-milovidov self-assigned this Aug 31, 2021
@alexey-milovidov alexey-milovidov merged commit 307ae34 into ClickHouse:master Aug 31, 2021
@azat azat deleted the integration-tests-improve-check branch August 31, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @alexey-milovidov @robot-clickhouse