Fix incorrect assertion during writing to StorageKafka#27885
Merged
qoega merged 2 commits intoClickHouse:masterfrom Aug 20, 2021
Merged
Fix incorrect assertion during writing to StorageKafka#27885qoega merged 2 commits intoClickHouse:masterfrom
qoega merged 2 commits intoClickHouse:masterfrom
Conversation
The problem it does not triggered in CI always because buffers was not destroyed by that time. Fixes: ClickHouse#26547
robot-clickhouse
added
the
pr-bugfix
Contributor
|
The same for rabbit |
kitaisreal
approved these changes
Aug 20, 2021
Member
|
@kitaisreal Does it fix #27820? |
robot-clickhouse
added
pr-improvement
Member
Author
Yes, this patch should fix it (updated commit description to reflect this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect assertion during writing to StorageKafka
Detailed description / Documentation draft:
The problem it does not triggered in CI always because buffers was not
destroyed by that time.
Fixes: #26547
Fixes: #27820
Introduced-in: #19886
Cc: @filimonov
NOTE: should be marked as
do not backportsince assertion is only in debug builds