Fix data race in ProtobufSchemas#27822
Merged
vitlibar merged 4 commits intoClickHouse:masterfrom Dec 11, 2021
Merged
Conversation
Member
|
@filimonov Why closed? |
Contributor
Author
|
@mergify rebase |
Contributor
|
Command
Hey, I reacted but my real name is @Mergifyio |
d6faa6d to
ea320c9
Compare
Contributor
Author
|
vitlibar
approved these changes
Dec 10, 2021
Member
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
This was referenced Dec 13, 2021
This was referenced Dec 13, 2021
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.8: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.9: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.3: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…3c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.12: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…3c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.11: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 13, 2021
…3c00cea7a826b151996d9f5478dc5c Cherry pick #27822 to 21.10: Fix data race in ProtobufSchemas
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Dec 15, 2021
Backport #27822 to 21.12: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 16, 2021
Backport #27822 to 21.11: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 16, 2021
Backport #27822 to 21.10: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 16, 2021
Backport #27822 to 21.9: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 16, 2021
Backport #27822 to 21.3: Fix data race in ProtobufSchemas
vitlibar
pushed a commit
that referenced
this pull request
Dec 16, 2021
Backport #27822 to 21.8: Fix data race in ProtobufSchemas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
This PR fixes a data race in
ProtobufSchemas::getMessageTypeForFormatSchema().Detailed description / Documentation draft:
It looks like the exact problem from #26643 (comment) was not reproduced, but we see some data race here related to
ClickHouse/src/Formats/ProtobufSchemas.cpp
Lines 77 to 78 in 9f5cd35