[WIP] add -Wno-reserved-identifier in necessary places for build with clang-13#27777
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Aug 19, 2021
Conversation
robot-clickhouse
added
the
pr-build
Author
|
PR is in draft state, because I haven't already fully check it solves all problems with clang-13. |
Member
|
We should fix the cause of these warnings, not to add suppressions. |
Author
|
Thank you for comment. I will try to do this later.12:36, 17 августа 2021 г., "alexey-milovidov" ***@***.***>:
We should fix the cause of these warnings, not to add suppressions.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
-- Отправлено из мобильного приложения Яндекс.Почты
|
added 2 commits
August 17, 2021 22:58
This reverts commit 84660f3.
Author
|
I have renamed that const, but some other errors still exists: will rename here too |
Author
|
but maybe errors in |
Member
|
Yes, but you cannot selectively suppress warnings from macro substitution. |
alexey-milovidov
approved these changes
Aug 18, 2021
alexey-milovidov
approved these changes
Aug 19, 2021
Member
|
Let's continue in next PR. |
Author
|
Thank you for advice and review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improve support for build with
clang-13.Detailed description / Documentation draft:
Some time ago building with clang-13 was completely failed.
After #27714 some errors were solved. But not all errors.
Example of errors caused by new diagnostic flag -Wreserved-identifier introduced in clang-13 and not exists in clang-12 (no mentions in doc for clang-12) listed in attached file
cmake-and-ninja-run-clang-13-reserved-identifier.txt. Versions of OS, compiler. cmake and ninja are the same as described in #27705 (comment)