Skip to content

Merging #20557 (Asynchronous inserts)#27537

Merged
CurtizJ merged 81 commits intoClickHouse:masterfrom
CurtizJ:merging-20557
Sep 16, 2021
Merged

Merging #20557 (Asynchronous inserts)#27537
CurtizJ merged 81 commits intoClickHouse:masterfrom
CurtizJ:merging-20557

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Aug 10, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Merging #20557.

TODO:

  • Better handling of huge number of async inserts with wait. Now such queries will fail, when max_concurrent_queries_for_all_users is reached. (Probably not in this PR).

@CurtizJ CurtizJ marked this pull request as ready for review September 8, 2021 14:54
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Sep 15, 2021

Flaky tests failure most likely related to known problem: deadlock in TRUNCATE query in non-replicated MergeTree. TRUNCATE queries as well as some other queries are run in 02015_async_inserts_stress_long.

<Error> executeQuery: Code: 473. DB::Exception: WRITE locking attempt on "test_d0l8d0.async_inserts" has timed out! (120000ms) Possible deadlock avoided. Client should retry. (DEADLOCK_AVOIDED) (version 21.11.1.8088) (from [::1]:37514) (comment: '/usr/share/clickhouse-test/queries/0_stateless/02015_async_inserts_stress_long.sh') (in query: TRUNCATE TABLE async_inserts)

@CurtizJ CurtizJ merged commit dfbb1ff into ClickHouse:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants