Add settings to check hyperscan regexp length.#27378
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Aug 8, 2021
Merged
Add settings to check hyperscan regexp length.#27378alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
Collaborator
Author
But why only |
Member
|
Fast test does not build ClickHouse with Hyperscan. |
Member
|
LGTM. Please add the exception to docker/test/fasttest/run.sh |
alexey-milovidov
approved these changes
Aug 8, 2021
Member
|
@Mergifyio update |
Contributor
|
Command
|
Contributor
|
Internal documentation ticket: DOCSUP-14089. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add two settings
max_hyperscan_regexp_lengthandmax_hyperscan_regexp_total_lengthto prevent huge regexp being used in hyperscan related functions, such asmultiMatchAny.Detailed description / Documentation draft:
.