Skip to content

Fixing reading of /proc/meminfo when kB suffix is not present#27361

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
myrrc:bugfix/error-parsing-proc-meminfo
Aug 7, 2021
Merged

Fixing reading of /proc/meminfo when kB suffix is not present#27361
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
myrrc:bugfix/error-parsing-proc-meminfo

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Aug 6, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

/proc/info contains metrics like

CmaFree: 0 kB
HugePages_Total: 1176 <- no kB suffix

which produce an error while parsing in AsynchronousMetrics.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 6, 2021
@myrrc myrrc changed the title Fixing reading of /proc/meminfo when kBsuffix is not present Fixing reading of /proc/meminfo when kB suffix is not present Aug 6, 2021
@alexey-milovidov alexey-milovidov self-assigned this Aug 6, 2021
@myrrc myrrc mentioned this pull request Aug 6, 2021
@alexey-milovidov alexey-milovidov merged commit fad30f6 into ClickHouse:master Aug 7, 2021
@myrrc myrrc deleted the bugfix/error-parsing-proc-meminfo branch August 7, 2021 17:20
robot-clickhouse pushed a commit that referenced this pull request Aug 7, 2021
alexey-milovidov added a commit that referenced this pull request Aug 8, 2021
Backport #27361 to 21.8: Fixing reading of /proc/meminfo when kB suffix is not present
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
Backport ClickHouse#27361 to 21.8: Fixing reading of /proc/meminfo when kB suffix is not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants