Using formatted string literals in clickhouse-test, extracted sort key functions and stacktraces printer#27228
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Aug 7, 2021
myrrc:improvement/tester-changes
Merged
Using formatted string literals in clickhouse-test, extracted sort key functions and stacktraces printer#27228alexey-milovidov merged 2 commits intoClickHouse:masterfrom myrrc:improvement/tester-changes
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
myrrc:improvement/tester-changes
Conversation
Closed
alexey-milovidov
approved these changes
Aug 7, 2021
Member
alexey-milovidov
left a comment
There was a problem hiding this comment.
Ok.
I'm not a python guy but the changes LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Not for changelog (changelog entry is not required)
.format().