Skip to content

Using formatted string literals in clickhouse-test, extracted sort key functions and stacktraces printer#27228

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
myrrc:improvement/tester-changes
Aug 7, 2021
Merged

Using formatted string literals in clickhouse-test, extracted sort key functions and stacktraces printer#27228
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
myrrc:improvement/tester-changes

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Aug 5, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):
Not for changelog (changelog entry is not required)

  • Lowering down pylint warnings (260 -> 180, only "line too long" or "statement too complex" left).
  • Multiple typos.
  • Using (multi line) formatted string literals instead of .format().
  • Extracted subprocess opening calls to a separate function.
  • Extracted stack traces printing function.
  • Extracted test skipping functions (bonus: -1 nest level).
  • Extracted test suites and tests inside a suite sorting key functions.
  • Setting ClickHouse default TCP port in main function.
  • Added spaces where necessary.

@myrrc myrrc mentioned this pull request Aug 5, 2021
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

I'm not a python guy but the changes LGTM.

@alexey-milovidov alexey-milovidov self-assigned this Aug 7, 2021
@alexey-milovidov alexey-milovidov merged commit af1d41a into ClickHouse:master Aug 7, 2021
@myrrc myrrc deleted the improvement/tester-changes branch August 7, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants