Skip to content

Some optimizations for constant conditions in JOIN ON#27021

Merged
vdimir merged 1 commit intoClickHouse:masterfrom
vdimir:join-on-condition-constant
Nov 8, 2021
Merged

Some optimizations for constant conditions in JOIN ON#27021
vdimir merged 1 commit intoClickHouse:masterfrom
vdimir:join-on-condition-constant

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 30, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add optimizations for constant conditions in JOIN ON, ref #26928

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jul 30, 2021
@kitaisreal kitaisreal self-assigned this Jul 30, 2021
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Aug 3, 2021

Do not merge before #21320 because of conflicts

UPD: ready

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@vdimir vdimir marked this pull request as draft October 7, 2021 10:15
@vdimir vdimir force-pushed the join-on-condition-constant branch from 4c6abdb to 9b3a737 Compare October 7, 2021 12:26
@vdimir vdimir marked this pull request as ready for review October 7, 2021 12:30
@vdimir vdimir force-pushed the join-on-condition-constant branch from 9b3a737 to 209a5d1 Compare October 8, 2021 09:48
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just refactoring in general.

@KochetovNicolai KochetovNicolai self-assigned this Oct 28, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2021

update

✅ Branch has been successfully updated

Details

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 8, 2021

AST fuzzer (UBSan) — ../src/Interpreters/ExpressionAnalyzer.cpp:555:19: runtime error

known issue, not related to changes
#30683

@vdimir vdimir force-pushed the join-on-condition-constant branch from adef123 to 4bc9798 Compare November 8, 2021 12:37
@vdimir vdimir merged commit 6f36931 into ClickHouse:master Nov 8, 2021
@vdimir vdimir deleted the join-on-condition-constant branch November 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants