01674_executable_dictionary_implicit_key: executable_dictionary: Use printf#26978
Conversation
|
Test fails in docker. We use Ubuntu there |
Let's see if printf works in both places. |
Looks like a normal situation, need to filter these messages in test? |
|
00537_quarters fails because of the timezone ( |
Looking at the test, it seems like it could be a bug in the test. The test is waiting for all subprocesses to finish and when the timeout is reached the process will but when a timeout is reached the process will kill the client, but that doesn't inmediately stops the query that was running in the server. If I'm not wrong it could happen that:
I haven't been able to reproduce it locally (even by adding sleeps) but it's something that I see possible. If all that is true, then I think the best idea is to use the signal as a way to break the loop, instead of a direct TERM or KILL. I'll look into it. |
|
@Mergifyio update |
|
Command
|
|
The failing test ( WITH toDateTime('1970-06-17 07:39:21', 'Africa/Monrovia') AS t
SELECT
toUnixTimestamp(t),
timeZoneOffset(t),
formatDateTime(t, '%F %T', 'Africa/Monrovia'),
toString(t, 'Africa/Monrovia')
Query id: e8484df3-58cc-4fc8-8fd1-9c3660425585
┌─toUnixTimestamp(t)─┬─timeZoneOffset(t)─┬─formatDateTime(t, '%F %T', 'Africa/Monrovia')─┬─toString(t, 'Africa/Monrovia')─┐
│ 14459031 │ -2670 │ 1970-06-17 07:39:51 │ 1970-06-17 07:39:21 │
└────────────────────┴───────────────────┴───────────────────────────────────────────────┴────────────────────────────────┘There is a 30 second diff between formatDateTime and toString. toString is correct according to https://www.epochconverter.com/timezones?q=14459031&tz=Africa%2FMonrovia |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
01674_executable_dictionary_implicit_key fails because it can't parse the output of the dictionary:
The problem is that echo requires -e to recognize scape sequences, for example:
I've tested this with GNU coreutils 8.32 with bash (Linux) and with zsh 5.8 (OSX 11.3.1) and they work the same way. Another option would be to replace echo and use printf instead.