Updated extractAllGroupsHorizontal - flexible limit on number of matches#26961
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Jul 31, 2021
Enmk:fix/extractAllGroupsHorizontal_max_matches_per_row
Merged
Updated extractAllGroupsHorizontal - flexible limit on number of matches#26961alexey-milovidov merged 3 commits intoClickHouse:masterfrom Enmk:fix/extractAllGroupsHorizontal_max_matches_per_row
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Enmk:fix/extractAllGroupsHorizontal_max_matches_per_row
Conversation
…hes per row. If it is not set via third argument, it deafults to previously hardcoded value 1000.
robot-clickhouse
added
the
pr-improvement
Member
|
Maybe better to do it with a setting? It is a sanity check - not something that makes sense to control dynamically via arguments. |
alexey-milovidov
added
the
st-discussion
Contributor
Author
Ok, now it is a setting |
alexey-milovidov
removed
the
st-discussion
alexey-milovidov
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it is not set via the third argument, it defaults to the previously hardcoded value 1000.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Updated extractAllGroupsHorizontal - upper limit on the number of matches per row can be set via optional third argument.
...
Detailed description / Documentation draft:
...