Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
vitlibar
force-pushed
the
refactor-sessions
branch
12 times, most recently
from
24c1e37 to
f883438
Compare
Contributor
|
Required for #22415 |
vitlibar
force-pushed
the
refactor-sessions
branch
9 times, most recently
from
de75532 to
90e40d3
Compare
vitlibar
force-pushed
the
refactor-sessions
branch
4 times, most recently
from
09b62ab to
25db9fc
Compare
vitlibar
force-pushed
the
refactor-sessions
branch
13 times, most recently
from
4bc5c1d to
660ce8b
Compare
vitlibar
force-pushed
the
refactor-sessions
branch
3 times, most recently
from
3b262d6 to
f7e9cae
Compare
vitlibar
force-pushed
the
refactor-sessions
branch
from
f7e9cae to
1597541
Compare
This is required to add system.session_log table.
vitlibar
force-pushed
the
refactor-sessions
branch
from
1597541 to
fabd719
Compare
2 tasks
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Sep 26, 2021
Before this patch:
$ clickhouse-client --database foo -q 'select 1'
Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)
After:
$ clickhouse-client --database foo -q 'select 1'
Received exception from server (version 21.11.1):
Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
(query: select 1)
Fixes: ClickHouse#26864 (cc @vitlibar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to add system.session_log table.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
This PR introduces a new class
Sessionwhich provides a set of utilities to authenticate, create a session context and query contexts for connections of any kind (TCP / HTTP / GRPC / MySQL / PostgreSQL / etc.) toclickhouse-server. The main idea of this PR is to move some common session-related code from multiple connection handlers to one place.