Skip to content

Try fix rabbitmq tests#26826

Merged
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:rabbit-fix-tests
Jul 27, 2021
Merged

Try fix rabbitmq tests#26826
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:rabbit-fix-tests

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jul 27, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 27, 2021
self.rabbitmq_docker_id = self.get_instance_docker_id('rabbitmq1')
logging.debug(f"RabbitMQ checking container try: {i}")
if self.wait_rabbitmq_to_start(throw=(i==4)):
break
Copy link
Copy Markdown
Member

@vitlibar vitlibar Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will help.

> docker logs vitbarteststoragerabbitmq_rabbitmq1_1

error: RABBITMQ_DEFAULT_PASS is set but deprecated
error: RABBITMQ_DEFAULT_USER is set but deprecated
error: deprecated environment variables detected

Please use a configuration file instead; visit https://www.rabbitmq.com/configure.html to learn more

I think we should add rabbitmq configuration file to docker_compose_rabbitmq.yml instead.

@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 27, 2021
Copy link
Copy Markdown
Member

@qoega qoega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have passed

@kssenii kssenii merged commit f2e599d into ClickHouse:master Jul 27, 2021
@kssenii kssenii self-assigned this Jul 27, 2021
robot-clickhouse pushed a commit that referenced this pull request Jul 27, 2021
robot-clickhouse pushed a commit that referenced this pull request Jul 27, 2021
robot-clickhouse pushed a commit that referenced this pull request Jul 27, 2021
robot-clickhouse pushed a commit that referenced this pull request Jul 27, 2021
robot-clickhouse pushed a commit that referenced this pull request Jul 27, 2021
kssenii added a commit that referenced this pull request Jul 28, 2021
Backport #26826 to 21.8: Try fix rabbitmq tests
kssenii added a commit that referenced this pull request Jul 28, 2021
Backport #26826 to 21.7: Try fix rabbitmq tests
kssenii added a commit that referenced this pull request Jul 28, 2021
Backport #26826 to 21.6: Try fix rabbitmq tests
kssenii added a commit that referenced this pull request Jul 28, 2021
Backport #26826 to 21.5: Try fix rabbitmq tests
kssenii added a commit that referenced this pull request Jul 28, 2021
Backport #26826 to 20.8: Try fix rabbitmq tests
robot-clickhouse pushed a commit that referenced this pull request Jul 28, 2021
kssenii added a commit that referenced this pull request Jul 29, 2021
Backport #26826 to 21.3: Try fix rabbitmq tests
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants