Add system.rocksdb and read rocksdb/rocksdb_TABLE options from config#26821
Merged
kssenii merged 2 commits intoClickHouse:masterfrom Jul 27, 2021
Merged
Add system.rocksdb and read rocksdb/rocksdb_TABLE options from config#26821kssenii merged 2 commits intoClickHouse:masterfrom
kssenii merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
azat
force-pushed
the
rocksdb-improvements
branch
from
d9b0f36 to
96ebfb8
Compare
v2: fix USE_ROCKSDB check (there is #cmakedefine01 so it is either 0/1, so we should not check with #ifdef)
azat
force-pushed
the
rocksdb-improvements
branch
from
96ebfb8 to
a21c49a
Compare
azat
force-pushed
the
rocksdb-improvements
branch
3 times, most recently
from
3ef887f to
3801605
Compare
v2: Cover rocksdb options in ClickHouse config v3: add missing __init__.py v4: Rework rocksdb options from config v5: add column_family_options support
azat
force-pushed
the
rocksdb-improvements
branch
from
3801605 to
8ef677b
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Expose rocksdb statistics via system.rocksdb table. Read rocksdb options from ClickHouse config (
rocksdb/rocksdb_TABLEkeys)Cc: @sundy-li
Follow-up for: #15073