Skip to content

Do not start new hedged connection if query was already canceled.#26820

Merged
KochetovNicolai merged 1 commit intomasterfrom
fix-26815
Jul 27, 2021
Merged

Do not start new hedged connection if query was already canceled.#26820
KochetovNicolai merged 1 commit intomasterfrom
fix-26815

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jul 26, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #26815

Now, ConnectionCollector makes connection live longer than query. It means we cannot use resources not owned by connection in drain.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 26, 2021
@KochetovNicolai
Copy link
Copy Markdown
Member Author

Stress test (memory) — Hung check failed - in DROP DATABASE test_in9ys4

@KochetovNicolai
Copy link
Copy Markdown
Member Author

test_storage_rabbitmq is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use after free in HedgedConnections::sendScalarsData

2 participants