Skip to content

Remove unneeded mutex during connection draining#26807

Merged
KochetovNicolai merged 1 commit intoClickHouse:masterfrom
amosbird:improvement2
Jul 27, 2021
Merged

Remove unneeded mutex during connection draining#26807
KochetovNicolai merged 1 commit intoClickHouse:masterfrom
amosbird:improvement2

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

@amosbird amosbird commented Jul 26, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Remove unneeded mutex during connection draining.

Detailed description / Documentation draft:
.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 26, 2021
@KochetovNicolai KochetovNicolai self-assigned this Jul 26, 2021
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Jul 26, 2021 

2021-07-26 16:23:33 01154_move_partition_long:                                              [ FAIL ] 66.82 sec. - having stderror:
2021-07-26 16:23:33 [d5089e908d24] 2021.07.26 16:23:31.355659 [ 167939 ] {58adf11c-e435-49d9-a469-60ce8ad9f366} <Error> executeQuery: Code: 60. DB::Exception: Table test_5i0ux0.dst_0 doesn't exist. (UNKNOWN_TABLE) (version 21.9.1.7577) (from [::1]:42574) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01154_move_partition_long.sh') (in query: SYSTEM SYNC REPLICA dst_0), Stack trace (when copying this message, always include the lines below):
2021-07-26 16:23:33 
2021-07-26 16:23:33 0. DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x90725fa in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 1. DB::Exception::Exception<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x918a063 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 2. void std::__1::__optional_storage_base<DB::Exception, false>::__construct<int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x10187331 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 3. DB::DatabaseCatalog::getTableImpl(DB::StorageID const&, std::__1::shared_ptr<DB::Context const>, std::__1::optional<DB::Exception>*) const @ 0x1017966a in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 4. DB::DatabaseCatalog::getTable(DB::StorageID const&, std::__1::shared_ptr<DB::Context const>) const @ 0x1017f688 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 5. DB::InterpreterSystemQuery::syncReplica(DB::ASTSystemQuery&) @ 0x107155b4 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 6. DB::InterpreterSystemQuery::execute() @ 0x10710742 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 7. DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) @ 0x108be24b in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 8. DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, bool) @ 0x108bc303 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 9. DB::TCPHandler::runImpl() @ 0x1115b20d in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 10. DB::TCPHandler::run() @ 0x1116de19 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 11. Poco::Net::TCPServerConnection::start() @ 0x13cfaf8f in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 12. Poco::Net::TCPServerDispatcher::run() @ 0x13cfca1a in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 13. Poco::PooledThread::run() @ 0x13e2f899 in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 14. Poco::ThreadImpl::runnableEntry(void*) @ 0x13e2bb2a in /usr/lib/debug/.build-id/37/e6e976d6f9f3766dcb65ad21c931e89c91a09b.debug
2021-07-26 16:23:33 15. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
2021-07-26 16:23:33 16. clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so

@tavplubix wanna check? :)

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jul 26, 2021 

2021-07-26 16:23:33 01154_move_partition_long:                                              [ FAIL ] 66.82 sec. - having stderror:
2021-07-26 16:23:33 [d5089e908d24] 2021.07.26 16:23:31.355659 [ 167939 ] {58adf11c-e435-49d9-a469-60ce8ad9f366} <Error> executeQuery: Code: 60. DB::Exception: Table test_5i0ux0.dst_0 doesn't exist. (UNKNOWN_TABLE) (version 21.9.1.7577) (from [::1]:42574) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01154_move_partition_long.sh') (in query: SYSTEM SYNC REPLICA dst_0), Stack trace (when copying this message, always include the lines below):
...

@tavplubix wanna check? :)

It's because clickhouse-test looks for messages to retry in stderr only:

zgrep -Fa "49037948-3a2f-4b98-bce0-fd597cc22cf0" clickhouse-server.log.gz                                                                                                            PIPE|0 ✔ 
2021.07.26 16:22:27.197338 [ 167919 ] {49037948-3a2f-4b98-bce0-fd597cc22cf0} <Debug> executeQuery: (from [::1]:34128) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01154_move_partition_long.sh') CREATE TABLE dst_0 (p UInt64, k UInt64, v UInt64) ENGINE=ReplicatedMergeTree('/test/01154_move_partition_long_test_5i0ux0/dst', '0') PARTITION BY p % 10 ORDER BY k
...
2021.07.26 16:22:31.277133 [ 167919 ] {49037948-3a2f-4b98-bce0-fd597cc22cf0} <Error> zkutil::EphemeralNodeHolder::~EphemeralNodeHolder(): Cannot remove /test/clickhouse/db/test_5i0ux0/log/query-0000000032/try: : Code: 999. Coordination::Exception: Session expired (Session expired). (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):

#26817

@KochetovNicolai KochetovNicolai merged commit 671c219 into ClickHouse:master Jul 27, 2021
tavplubix added a commit that referenced this pull request Mar 11, 2023
@tavplubix
Revert "Merge pull request #26807 from amosbird/improvement2"
13aa2ce 
This reverts commit 671c219, reversing
changes made to ee13f2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amosbird @KochetovNicolai @tavplubix @robot-clickhouse