CH local: Treat localhost:port as a remote database#26736
Merged
akuzm merged 2 commits intoClickHouse:masterfrom Jul 27, 2021
Merged
CH local: Treat localhost:port as a remote database#26736akuzm merged 2 commits intoClickHouse:masterfrom
akuzm merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-backward-incompatible
Contributor
|
I think we already have logic for this -- all localhost IPs except .1 are treated as remote.
Is this sufficient? |
Member
Author
What do you think @davidmanzanares? One issue it doesn't cover would be using |
|
Oh, I didn't know about that. Yes, for me it is sufficient. Although, personally, I think @Algunenano 's behavior is less error prone. |
Member
Author
|
Added a commit to ignore a ASAN warning (not an error, it's just saying that it can't handle some things) which is already ignored in other places like stress tests. |
akuzm
approved these changes
Jul 27, 2021
Contributor
|
The tests are flaky/broken in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Under clickhouse-local, always treat local addresses with a port as remote.
Detailed description / Documentation draft:
Before this change localhost:default_port would be treated as a self-connection, while now it will try to connect to a remote database. Connections to local addresses without port will still be considered local.
For example:
remote('localhost', 'system.tables'-> Selfremote('127.0.0.1', 'system.tables')-> Selfremote('127.0.0.1:9000', 'system.tables')-> ExternalNote that this only affects clickhouse-local.
I'm considering it a backward incompatible change since there was a test checking the old behaviour.
Closes #26712