ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread#26703
Merged
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom Jul 27, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
Member
|
Hm, it seem to me strange to add another one mutex to |
Member
Author
Sure, that makes sense to me too. I'll revert those changes and try to fix only #26694 by fixing the caller. |
Algunenano
changed the title
Algunenano
force-pushed
the
threadpool_safety
branch
from
834e242 to
61a90fa
Compare
Member
Author
|
rabbitmq are broken everywhere, there are some flaky tests and I can't see the result of the functional tests (internal Yandex link) so I don't know if it's related or not. |
Member
|
|
nikitamikhaylov
approved these changes
Jul 27, 2021
This was referenced Jul 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2021
… handle the join to the collector_thread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2021
… handle the join to the collector_thread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2021
… handle the join to the collector_thread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2021
… handle the join to the collector_thread
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2021
… handle the join to the collector_thread
nikitamikhaylov
added a commit
that referenced
this pull request
Jul 29, 2021
Backport #26703 to 21.3: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
nikitamikhaylov
added a commit
that referenced
this pull request
Jul 29, 2021
Backport #26703 to 21.6: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 2, 2021
Backport #26703 to 21.8: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 2, 2021
Backport #26703 to 21.5: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 2, 2021
Backport #26703 to 21.7: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
zhanglistar
pushed a commit
to zhanglistar/ClickHouse
that referenced
this pull request
Nov 12, 2021
…e mutex to handle the join to the collector_thread
zhanglistar
pushed a commit
to zhanglistar/ClickHouse
that referenced
this pull request
Nov 12, 2021
Backport ClickHouse#26703 to 21.8: ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
ParallelFormattingOutputFormat: Use mutex to handle the join to the collector_thread (#26694)
Detailed description / Documentation draft:
Fixes #26694