Add round-robin support for clickhouse-benchmark#26607
Add round-robin support for clickhouse-benchmark#26607alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
|
What's the purpose of it? |
| { | ||
| if (!connection_description.empty()) | ||
| connection_description += ","; | ||
| connection_description += ", "; |
There was a problem hiding this comment.
This will make it impossible to distinguish list of hosts from other columns, since other columns is printed via , too, i.e.:
Before:
127.1:9000,127.2:9000, queries 2, QPS: 48.036, RPS: 48.036, MiB/s: 0.000, result RPS: 48.036, result MiB/s: 0.000.
After:
127.1:9000, 127.2:9000, queries 2, QPS: 48.036, RPS: 48.036, MiB/s: 0.000, result RPS: 48.036, result MiB/s: 0.000.
There was a problem hiding this comment.
I don't like lack of whitespace after comma 😿
This option will just change the output, so instead of differentiate hosts between each other, statistics will be accounted for all hosts in summary, i.e. before: after: So latency and others will be accounted in summary, maybe useful for benchmarking the cluster. AFAIU initial mode was added for perf tests.
Yes, but with |
|
Ok. But why it is needed? |
|
|
Maybe instead add another mode that will do requests to all hosts in parallel? |
|
I was thinking more about this solution and found it Ok. |
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add round-robin support for clickhouse-benchmark (it does not differ from the regular multi host/port run except for statistics report).