Skip to content

fix lagInFrame for nullable types#26521

Merged
akuzm merged 3 commits intomasterfrom
aku/lag-in-frame-nullable
Jul 21, 2021
Merged

fix lagInFrame for nullable types#26521
akuzm merged 3 commits intomasterfrom
aku/lag-in-frame-nullable

Conversation

@akuzm
Copy link
Copy Markdown
Contributor

@akuzm akuzm commented Jul 19, 2021

Fixes #26115

lagInFrame(x) still returns default value of the type if the row is out of frame, but you can write lagInFrame(toNullable(x)) to get Nulls.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 19, 2021
@akuzm
Copy link
Copy Markdown
Contributor Author

akuzm commented Jul 21, 2021

The last commit was a whitespace change.
Failing integration tests for previous commit are flaky. Yandex check seems to be broken by something else.

@akuzm akuzm merged commit 6ae4031 into master Jul 21, 2021
@akuzm akuzm deleted the aku/lag-in-frame-nullable branch July 21, 2021 11:10
makeavish added a commit to SigNoz/signoz that referenced this pull request May 5, 2022
ankitnayan pushed a commit to SigNoz/signoz that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lagInFrame and leadInFrame does not return NULL for calculated target rows which are out of frame.

2 participants