Check hash function at table creation#26256
Merged
CurtizJ merged 6 commits intoClickHouse:masterfrom Jul 14, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-improvement
CurtizJ
reviewed
Jul 13, 2021
CurtizJ
approved these changes
Jul 13, 2021
Member
|
@zxc111 It's better not to explicitly create database in functional tests. Instead |
Contributor
|
Internal documentation ticket: DOCSUP-11657. |
6 tasks
macobo
added a commit
to PostHog/posthog
that referenced
this pull request
Aug 23, 2021
This was "broken" upsteam in 21.7 in ClickHouse/ClickHouse#822 / ClickHouse/ClickHouse#26256 In reality if we ever tried to use SAMPLE BY it would just have failed due to the wrong column. Fixed by hashing the UUID for sampling.
This was referenced Aug 23, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Check hash function at table creation, not at sampling.
Add settings in MergeTreeSettings, if someone create a table with incorrect sampling column but sampling never be used, disable this settings for starting the server without exception.
closes #822