Skip to content

Added failing test #24404#26179

Merged
alexey-milovidov merged 3 commits intomasterfrom
untuple-transformers-msan
Jul 10, 2021
Merged

Added failing test #24404#26179
alexey-milovidov merged 3 commits intomasterfrom
untuple-transformers-msan

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jul 10, 2021

Changelog category (leave one):

  • Bug Fix

Changelog entry:
Fix potential crash if more than one untuple expression is used.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 10, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Actually it fails fairly well even in release build.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

milovidov-desktop :) SELECT untuple((1.0, 2)), untuple((1, *)) FROM (SELECT 123)

SELECT
    untuple((1., 2)),
    untuple((1, *))
FROM
(
    SELECT 123
)

Query id: 62123bd3-0d56-45c6-8037-12909cbb3d2e


0 rows in set. Elapsed: 0.002 sec. 

Received exception from server (version 21.9.1):
Code: 49. DB::Exception: Received from localhost:9000. DB::Exception: Bad cast from type DB::ColumnVector<double> to DB::ColumnVector<char8_t>. 

milovidov-desktop :) SELECT untuple((1.0, 2)), untuple((NULL, *)) FROM (SELECT 123)

SELECT
    untuple((1., 2)),
    untuple((NULL, *))
FROM
(
    SELECT 123
)

@alexey-milovidov alexey-milovidov added crash Crash / segfault / abort fuzz Problem found by one of the fuzzers labels Jul 10, 2021
@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jul 10, 2021
@alexey-milovidov alexey-milovidov self-assigned this Jul 10, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Unortunately Arcadia has a test that assumes implementation specific name for untupled columns.
But it's more important to merge this PR soon.

robot-clickhouse pushed a commit that referenced this pull request Jul 10, 2021
alexey-milovidov added a commit that referenced this pull request Jul 11, 2021
alexey-milovidov added a commit that referenced this pull request Jul 11, 2021
alexey-milovidov added a commit that referenced this pull request Jul 11, 2021
alexey-milovidov added a commit that referenced this pull request Jul 11, 2021
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
zhanglistar pushed a commit to zhanglistar/ClickHouse that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Crash / segfault / abort fuzz Problem found by one of the fuzzers pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants