Add setting optimize_move_to_prewhere_if_final#25940
Merged
kssenii merged 4 commits intoClickHouse:masterfrom Jul 4, 2021
Merged
Add setting optimize_move_to_prewhere_if_final#25940kssenii merged 4 commits intoClickHouse:masterfrom
kssenii merged 4 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
Member
|
@Mergifyio update |
Contributor
|
Command
|
| } | ||
| } | ||
|
|
||
| bool InterpreterSelectQuery::moveToPrewhereIfFinal() |
Member
There was a problem hiding this comment.
Let's rename to shouldMoveToPrewhere and also include the check settings.optimize_move_to_prewhere inside the function.
alexey-milovidov
approved these changes
Jul 3, 2021
Contributor
|
Internal documentation ticket: DOCSUP-11547. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added setting
optimize_move_to_prewhere_if_final. If query hasFINAL, the optimizationmove_to_prewherewill be enabled only if bothoptimize_move_to_prewhereandoptimize_move_to_prewhere_if_finalare enabled. Closes #8684.