Fix bug in execution of TTL GROUP BY#25743
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
Member
Author
|
No related failures. |
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
Member
Author
|
Looks like in a very rare cases 01280_ttl_where_group_by completely ignores TTL |
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
CurtizJ
reviewed
Jul 6, 2021
Member
CurtizJ
left a comment
CurtizJ
left a comment
There was a problem hiding this comment.
You set finished flag if isMinTTLExpired is true. Looks like it can lead to non-pruned partially expired parts. Shouldn't we use isMaxTTLExpired instead?
Comment on lines
+114
to
+115
| if (!part.ttl_infos->hasAnyNonFinishedTTLs()) | ||
| return false; |
Member
There was a problem hiding this comment.
Why we return false in this case?
CurtizJ
approved these changes
Jul 6, 2021
Member
Author
|
No related failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in
TTLwithGROUP BYexpression which refuses to executeTTLafter first execution in part.No backport because of changes in
ttl.txt. Finally fixestest_replicated_ttl/test.py::test_ttl_compatibility.