Skip to content

Backport #25370 to 21.3: Fix lost WHERE condition in expression-push-down optimization of query plan#25455

Merged
vitlibar merged 3 commits into21.3from
backport/21.3/25370
Jun 22, 2021
Merged

Backport #25370 to 21.3: Fix lost WHERE condition in expression-push-down optimization of query plan#25455
vitlibar merged 3 commits into21.3from
backport/21.3/25370

Conversation

@robot-clickhouse
Copy link
Copy Markdown
Member

Original pull-request #25370
Cherry-pick pull-request #25442

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-clickhouse robot-clickhouse added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Jun 18, 2021
@vitlibar
Copy link
Copy Markdown
Member

@KochetovNicolai Please help to fix the compilation.

@vitlibar vitlibar merged commit cd87d4a into 21.3 Jun 22, 2021
@vitlibar vitlibar deleted the backport/21.3/25370 branch June 22, 2021 10:46
@KochetovNicolai
Copy link
Copy Markdown
Member

@vitlibar you have merge it too early

2021-06-22 13:11:00 01913_join_push_down_bug:                                               [ FAIL ] 0.10 sec. - return code 115
2021-06-22 13:11:00 [7d1627c41c66] 2021.06.22 13:11:00.258127 [ 160 ] {ed22d544-e4cc-4f6e-ab47-ffdd9b9f24a1} <Error> executeQuery: Code: 115, e.displayText() = DB::Exception: Setting query_plan_filter_push_down is neither a builtin setting nor started with the prefix 'custom_' registered for user-defined settings (version 21.3.13.7240) (from [::1]:36820) (comment: /usr/share/clickhouse-test/queries/0_stateless/01913_join_push_down_bug.sql)

@KochetovNicolai
Copy link
Copy Markdown
Member

Will try to fix it in 21.3 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants