Skip to content

Tool for conversion of ZooKeeper data into clickhouse-keeper snapshot#25428

Merged
alesapin merged 22 commits intomasterfrom
zookeeper_snapshots
Jun 29, 2021
Merged

Tool for conversion of ZooKeeper data into clickhouse-keeper snapshot#25428
alesapin merged 22 commits intomasterfrom
zookeeper_snapshots

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Other

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add clickhouse-keeper-converter tool which allows converting zookeeper logs and snapshots into clickhouse-keeper snapshot format.

@robot-clickhouse robot-clickhouse added the pr-other Pull request with changes not fitting to other categories label Jun 17, 2021
@alesapin alesapin marked this pull request as draft June 17, 2021 18:37
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jun 17, 2021

TODO:

  • Integration tests with some data.
  • Implement setACL while parsing data

@robot-ch-test-poll3 robot-ch-test-poll3 added the submodule changed At least one submodule changed in this PR. label Jun 17, 2021
@alesapin alesapin marked this pull request as ready for review June 22, 2021 10:51
@robot-ch-test-poll4 robot-ch-test-poll4 removed the submodule changed At least one submodule changed in this PR. label Jun 22, 2021
@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

Tests OK, let's check one more time.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 23, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

test_version_update_after_mutation didn't fails before....

@alesapin
Copy link
Copy Markdown
Member Author

Still cannot investigate these failures.....

@alesapin
Copy link
Copy Markdown
Member Author

$ pytest -ss test_version_update_after_mutation/test.py ========================================================== 2 passed in 91.48s (0:01:31) ===============================================

@alesapin
Copy link
Copy Markdown
Member Author

All failures look flaky. I'm fixing them:

  1. Fix flaky test and wrong message #25772
  2. Fix bug in execution of TTL GROUP BY #25743

@alesapin
Copy link
Copy Markdown
Member Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 28, 2021

Command update: success

Branch has been successfully updated

@alesapin alesapin merged commit cdc95fa into master Jun 29, 2021
@alesapin alesapin deleted the zookeeper_snapshots branch June 29, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-other Pull request with changes not fitting to other categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants