Update NuRaft buffer to 64 bit size#25421
Conversation
| enum class ChangelogVersion : uint8_t | ||
| { | ||
| V0 = 0, | ||
| V1 = 1, /// with 64 bit buffer header |
There was a problem hiding this comment.
It is not in production, why even introduce a new version?
There was a problem hiding this comment.
Actually it is Ok to just test the versioning right now.
We can drop support for old versions later.
There was a problem hiding this comment.
mmm, why not?) 1 Looks better than 0)
|
Maybe search for other 32bit sizes and offsets in NuRaft... |
|
A lot of tests failed. I don't understand why. Need to investigate. |
|
Keeper failures: Looks unrelated. Database replicated failure also looks unrelated, there was no even |
|
Ok, it should be more clear with #25459 |
|
cannot merge anything. Integration tests are completely broken. |
|
For some reason sometimes we have eth1 instead of eth0 in the fetches test. I'll just add it as a fallback. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Forward/backward incompatible change of maximum buffer size in clickhouse-keeper. Better to do it now (before production), than later.
Currently, a lot of ClickHouse users have 6GB+ ZooKeeper snapshots. In Keeper they are much smaller because of compression, around 1.5GB. But this looks quite dangerous and I think it's better to change the max size of the internal buffer in NuRaft to 64 bits.