Fix lost WHERE condition in expression-push-down optimization of query plan#25370
Merged
KochetovNicolai merged 3 commits intomasterfrom Jun 17, 2021
Merged
Conversation
robot-clickhouse
added
doc-alert
pr-feature
alexey-milovidov
approved these changes
Jun 16, 2021
robot-clickhouse
added
pr-bugfix
KochetovNicolai
changed the title
|
|
||
| INSERT INTO test VALUES (1,0,1),(1,0,2),(1,0,3),(1,0,4),(1,0,5),(1,0,6),(1,1,7),(0,0,7); | ||
|
|
||
| set query_plan_filter_push_down = true; |
Member
There was a problem hiding this comment.
Never thought that it works (true).
| if (cur.node->type != ActionsDAG::ActionType::ARRAY_JOIN && cur.node->type != ActionsDAG::ActionType::INPUT) | ||
| allowed_nodes.emplace(cur.node); | ||
| } | ||
| else if (is_conjunction) |
Member
There was a problem hiding this comment.
Maybe add some comments?
Member
Author
|
Failed integration tests are known. |
KochetovNicolai
deleted the
disable-query_plan_filter_push_down-because-of-25368
branch
This was referenced Jun 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 18, 2021
…down optimization of query plan
KochetovNicolai
added a commit
that referenced
this pull request
Jun 18, 2021
Backport #25370 to 21.6: Fix lost WHERE condition in expression-push-down optimization of query plan
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 18, 2021
…down optimization of query plan
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 18, 2021
…down optimization of query plan
vitlibar
pushed a commit
that referenced
this pull request
Jun 21, 2021
Backport #25370 to 21.5: Fix lost WHERE condition in expression-push-down optimization of query plan
vitlibar
pushed a commit
that referenced
this pull request
Jun 22, 2021
Backport #25370 to 21.3: Fix lost WHERE condition in expression-push-down optimization of query plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix lost
WHEREcondition in expression-push-down optimization of query plan (settingquery_plan_filter_push_down = 1by default). Fixes #25368