Introduced MergeTask and MutateTask#25165
Merged
nikitamikhaylov merged 124 commits intoClickHouse:masterfrom Sep 16, 2021
Merged
Introduced MergeTask and MutateTask#25165nikitamikhaylov merged 124 commits intoClickHouse:masterfrom
nikitamikhaylov merged 124 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
cc94c52 to
ce62354
Compare
robot-ch-test-poll1
added
the
submodule changed
Member
Author
|
@Mergifyio update |
Contributor
|
Command
|
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
f2f7d7e to
22e6571
Compare
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
45d29b8 to
5c1c2a3
Compare
nikitamikhaylov
removed
the
submodule changed
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
8e179d5 to
7b89c2e
Compare
robot-ch-test-poll1
added
the
submodule changed
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
51397fa to
2f179af
Compare
robot-ch-test-poll3
removed
the
submodule changed
nikitamikhaylov
force-pushed
the
merge-task-save
branch
from
8191198 to
ebcedd8
Compare
|
|
||
| bool ReplicatedMergeMutateTaskBase::executeImpl() | ||
| { | ||
| MemoryTrackerThreadSwitcherPtr switcher; |
Member
Author
There was a problem hiding this comment.
Why? It is RAII class.
Need to add comment, of course
Member
There was a problem hiding this comment.
That's ok, we also call dtor for std::optional :)
Just one needless heap allocation ...
| * then it will be executed for a long time, because the result of the merge is not really needed immediately. | ||
| * It is better to merge small parts as soon as possible. | ||
| */ | ||
| class MergeTask |
Member
There was a problem hiding this comment.
Well, we should find some way how to improve this code.
It is mainly only moved code, but now it became a little bit unreadable.
We can kind of leave it that way, but it will be a tech depth. I am ok if we have another one following pr with it.
A couple of ideas what to do:
- constructor has a lot of params - maybe group them into one or several structs, also add comment to them
- there are several states and according functions, but prev variables from stack are now all together. maybe we could create separate struct for each stage, which is alive only while stage is being executed
- also maybe replace enum with stages to an array of member functions + current index - because we execute them in order.
Member
There was a problem hiding this comment.
BTW MutateTask looks more readable
nikitamikhaylov
changed the title
Member
Author
|
Some tests become flaky after my changes or this PR contains a bug. Nevertheless I merge it and will fix all issues ASAP. Because I don't want to resolve conflicts every day. |
This was referenced Sep 23, 2021
This was referenced Oct 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Added an ability to suspend and resume a process of a merge. This is needed for a better scheduling and controlling of merges execution. #22381